Skip to content

Fix warning messages causing console errors#5112

Merged
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9797
Aug 8, 2023
Merged

Fix warning messages causing console errors#5112
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9797

Conversation

@nolanpro
Copy link
Copy Markdown
Contributor

@nolanpro nolanpro commented Aug 8, 2023

Issue & Reproduction Steps

See jira issue. Console errors were being shown when using custom import.

Solution

  • Some object attributes were missing. This fix accounts for missing attributes in both basic and custom import.
  • Additionally, I refactored the messages to give context so the translator can make better translations

How to Test

  • Download the attached process and follow steps in the video in the jira issue

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@nolanpro nolanpro requested a review from agustinbusso August 8, 2023 18:42
Copy link
Copy Markdown
Contributor

@agustinbusso agustinbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct, errors no showing in the console. Messaging improved

Screen.Recording.2023-08-08.at.15.57.40.mov

@ryancooley ryancooley merged commit 92f33f4 into develop Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants